suggestions

#1 · May 19, 2019, 1:06 pm

Possible to add an option for role to can not participate in polls ? (sorry for my english :p )
I modified part of the plugin’s source code to display a css class “locked-topic” in a good place to display the locks icon, possible to add my code ?

In includes/forum.php line 765

  function render_topic_element($topic_object, $topic_type = 'topic-normal', $show_topic_location = false) {
        $lastpost_data = $this->get_lastpost_in_topic($topic_object->id);
        $unread_status = $this->unread->get_status_topic($topic_object->id);
        $topic_title = esc_html(stripslashes($topic_object->name));
        echo '<div class="content-element topic '.$topic_type.'">';
          echo '<div class="topic-status far fa-comments ';
                echo $unread_status;
                 if ($this->is_topic_closed($topic_object->id)) { echo " locked-topic"; }
                 echo '">
                 </div>';
            echo '<div class="topic-name">';

with class lock i surcharge in my css a locked icon

#2 · May 21, 2019, 11:40 am

Hello @kwiz

Thank you for your suggestions. I will check if I can add additional permission-settings for polls in a future update.

Usually, a icon for closed topics should already be shown next to the title (see image below). Is this not displayed correctly on your website?

Uploaded files:

If you want to support the development of Asgaros Forum, you can leave a good review or donate. Thank you very much!

#3 · May 23, 2019, 2:51 am

yes yes the icon display, but with my code, we add a additional possibility for the dev to add an icon here (in this exemple i surcharge the classic icon in css for display locked icon and i hide the icon as on your example

#4 · May 23, 2019, 1:41 pm

It’s a good idea to replace the standard icon of an open topic with a lock icon for closed topics.

#5 · May 23, 2019, 4:53 pm

Hello @kwiz @rusev

Actually a couple of versions before the icon was placed at exactly the same position which you are suggesting now. The reason why I changed this to the side next of the topic-name is the following:

I think the closed and the sticky status are equally important
Topics can be closed and sticky at the same time
Now there is a problem: Only one icon can be shown which can lead to inconsistency if the other one is hidden

Because of this, I decided to add them both – and an additional icon for polls – next to the topic so all possible status-indicators can be shown. This is also a possible approach for other forum-solutions, check out the following for example (you can see the icons in the top area for some closed/sticky topics):

https://www.computerbase.de/forum/forums/arbeitsspeicher.49/

RUSev has reacted to this post.

If you want to support the development of Asgaros Forum, you can leave a good review or donate. Thank you very much!

#6 · May 23, 2019, 9:42 pm

In fact With my proposition , we adding the locked-topic class but it does not automatically overwrite the icon, this css class gives the possibility for the developers to overload in css on their side

#7 · May 23, 2019, 9:44 pm

it gives more choice for the dev and it interests me.